Skip to content

fixed #14726 - removed explicit usage of Visual Studio CMake generators from CI#8532

Merged
firewave merged 1 commit intocppcheck-opensource:mainfrom
firewave:cmake-g
May 6, 2026
Merged

fixed #14726 - removed explicit usage of Visual Studio CMake generators from CI#8532
firewave merged 1 commit intocppcheck-opensource:mainfrom
firewave:cmake-g

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented May 5, 2026

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented May 5, 2026

Somehow they switched windows-2025 to Visual Studio 2026 although they introduced a separate runner for that. I wouldn't be surprised if it was done accidentally since GitHub has been prone to plunders over the past few months.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented May 6, 2026

See actions/runner-images#14004.

@firewave firewave changed the title removed explicit usage of Visual Studio CMake generators from CI fixed #14726 - removed explicit usage of Visual Studio CMake generators from CI May 6, 2026
@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented May 6, 2026

Even without the breakage specifying the generators explicitly was unnecessary.

@firewave firewave marked this pull request as ready for review May 6, 2026 09:33
@firewave firewave merged commit ce9227f into cppcheck-opensource:main May 6, 2026
70 checks passed
@firewave firewave deleted the cmake-g branch May 6, 2026 09:33
@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented May 6, 2026

The release build might still be broken as we use the solution file which has a different file extension with Visual Studio 2026. Let's wait a bit to see what the feedback is on this behavior change before adjusting that workflow.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented May 7, 2026

It appears this was actually intentional and is here to stay: https://github.blog/changelog/2026-02-05-github-actions-early-february-2026-updates/#windows-server-2025-with-visual-studio-2026-image-now-available-for-github-hosted-runners.

But somehow none of what was communicated actually aligns with what is happening and is documented - so I will give it another few days before fixing the release build and simplecpp since I do not want to flip-flop on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants